Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More UTs and fix regression tests #116

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Aug 27, 2024

Adding more UTs to different packages and fixing regression tests by using latest kurtosis-cdk changes.

@goran-ethernal goran-ethernal requested a review from a team as a code owner August 27, 2024 13:36
@goran-ethernal goran-ethernal marked this pull request as draft August 27, 2024 13:36
@goran-ethernal goran-ethernal self-assigned this Aug 27, 2024
@goran-ethernal goran-ethernal force-pushed the CDK-363-Quality-gate-for-the-DAC branch 6 times, most recently from 20200dd to d138f0f Compare August 28, 2024 08:17
@goran-ethernal goran-ethernal changed the title More UTs More UTs and fix regression tests Aug 28, 2024
@goran-ethernal goran-ethernal force-pushed the CDK-363-Quality-gate-for-the-DAC branch from d138f0f to 97addb4 Compare August 28, 2024 08:48
@goran-ethernal goran-ethernal marked this pull request as ready for review August 28, 2024 09:49
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

client/client_test.go Show resolved Hide resolved
config/config_test.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 28, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@goran-ethernal goran-ethernal merged commit 51f4b0b into main Aug 28, 2024
8 of 9 checks passed
@goran-ethernal goran-ethernal deleted the CDK-363-Quality-gate-for-the-DAC branch August 28, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants