Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/banana #95

Merged
merged 10 commits into from
Jul 12, 2024
Merged

Feature/banana #95

merged 10 commits into from
Jul 12, 2024

Conversation

arnaubennassar
Copy link
Contributor

@arnaubennassar arnaubennassar commented Jun 20, 2024

  • Refactor to use contracts from cdk-contrats-tooling
  • Add new endpoint to support banana signature schema
  • Remove integration test as it will happen on the main CDK repo

⚠️ The code of the PR is done, however, waiting on sequence sender to be updated so we can have the full E2E test using the new endpoint and check that this actually works

@arnaubennassar arnaubennassar requested a review from a team as a code owner June 20, 2024 12:05
@arnaubennassar arnaubennassar marked this pull request as draft June 20, 2024 12:05
Copy link

sonarcloud bot commented Jul 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@goran-ethernal goran-ethernal merged commit 72ae676 into main Jul 12, 2024
7 of 9 checks passed
@goran-ethernal goran-ethernal deleted the feature/banana branch July 12, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants