Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary DB transactions use #99

Merged
merged 8 commits into from
Jun 27, 2024

Conversation

begmaroman
Copy link
Contributor

No description provided.

@begmaroman begmaroman requested a review from a team as a code owner June 26, 2024 17:36
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, logic is simplified and unnecessary abstractions removed, so I like it.

db/db.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jun 27, 2024

@begmaroman begmaroman merged commit 97f3683 into main Jun 27, 2024
8 of 9 checks passed
@begmaroman begmaroman deleted the feature/refactoring-and-simplification branch June 27, 2024 15:27
Copy link
Collaborator

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants