Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pullupstream/v0.5.0 #63

Merged
merged 46 commits into from
Feb 7, 2024
Merged

Pullupstream/v0.5.0 #63

merged 46 commits into from
Feb 7, 2024

Conversation

rachit77
Copy link

@rachit77 rachit77 commented Jan 30, 2024

This PR fetches v0.5.0 changes of the ZK-EVM node and bumps the cdk-data-availiability dependency to v0.4.0.

agnusmor and others added 30 commits January 23, 2024 18:35
* fix Leaves smtproof

* pointer protection

* fix unit test
…0xPolygonHermez#3129)

* add l2block log dump when storing error. refactor ProcessBatchV2 logs

* add AddL2Block log

* fix index AddL2Block log

* use aux variable to avoid reusing poiner

---------

Co-authored-by: Toni Ramírez <[email protected]>
…storing L2Block. Logs changes (0xPolygonHermez#3134)

* fix l2 hash when to is nill

* get l2 hash from executor

* fix use tx L2 hash returned by the executor when storing L2Block. Logs changes

* fix linter

* add L2block tracking number to process tx logs

* fix ProcessBatchV2 log format

* fix UTs. set useMainExecGenerated to true

* set prover image to v4.0.0-RC30

* test setting useMainExecGenerated = false

* fix independent_test

* fix non-e2e tests

---------

Co-authored-by: Toni Ramírez <[email protected]>
* if got an error getting lastBlock produce a SIGSEGV

* reduce info logs

* fix unittest
* fix missingBookMark

* fix missingBookMark

* fixes

* fix

* fix

* fix seq-sender config

* fixes

* doc
* improve open new wipL2Block logs

* fix wipL2Block deltaTimestamp
…in the pool (0xPolygonHermez#3156)

* set DEFAULT 0 when creatingtransaction.used_sha256_hashes field in the pool

* update prover image to v4.0.0
* add cardona testnet (0xPolygonHermez#2909)
* update config
* update cardona genesis

---------

Co-authored-by: Thiago Coimbra Lemos <[email protected]>
* new fields in stream

* update test

* remove unused constant

* add UpgradeEtrogBatchNumber handling to stream

* doc

* add log to test

* add log to test

* add protection

* add check

* fix

* fix
* fix case emtpy batch and unittest

* fix error in conversion

* fix unittest
@Stefan-Ethernal Stefan-Ethernal changed the base branch from pullupstream/v0.5.0-RC4 to pullupstream/v0.5.0-RC23 January 31, 2024 13:32
.github/workflows/release.yml Outdated Show resolved Hide resolved
cmd/main.go Outdated Show resolved Hide resolved
config/cardonagenesis.go Outdated Show resolved Hide resolved
config/config.go Outdated Show resolved Hide resolved
config/environments/cardona/example.env Outdated Show resolved Hide resolved
Base automatically changed from pullupstream/v0.5.0-RC23 to pullupstream/v0.5.0-RC4 February 1, 2024 10:29
@vcastellm vcastellm changed the base branch from pullupstream/v0.5.0-RC4 to develop February 2, 2024 16:08
Copy link

@christophercampbell christophercampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than missing comment prefix in config file.

And one comment: I presume the the migration changes are coming from upstream? At some point, once we have installs, we should consider migration files fixed and only accept/write new migrations files.

config/environments/testnet/postgresql.conf Outdated Show resolved Hide resolved
@christophercampbell
Copy link

If the testnet configuration is breaking CI, it might be because the postgres conf file is borked (see above)

@Stefan-Ethernal
Copy link
Collaborator

If the testnet configuration is breaking CI, it might be because the postgres conf file is borked (see above)

Nope, this is not the case, we have removed all testnet configuration and ZK-EVM node e2e tests are green, only the one which tests DAC is failing (since DA nodes are failing to start up with the error suggesting that contract is not deployed on an expected address):

2024-02-05T16:41:14.975Z	[31mFATAL[0m	cmd/main.go:104	no contract code at given address
/src/log/log.go:140 github.com/0xPolygon/cdk-data-availability/log.appendStackTraceMaybeArgs()
/src/log/log.go:221 github.com/0xPolygon/cdk-data-availability/log.Fatal()
/src/cmd/main.go:104 main.start()
/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:274 github.com/urfave/cli/v2.(*Command).Run()
/go/pkg/mod/github.com/urfave/cli/[email protected]/command.go:267 github.com/urfave/cli/v2.(*Command).Run()
/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:332 github.com/urfave/cli/v2.(*App).RunContext()
/go/pkg/mod/github.com/urfave/cli/[email protected]/app.go:309 github.com/urfave/cli/v2.(*App).Run()
/src/cmd/main.go:52 main.main()
/usr/local/go/src/runtime/proc.go:250 runtime.main()
	{"pid": 1, "version": "v0.0.3-30-gc030128"}
main.start

@rachit77 rachit77 merged commit 283971e into develop Feb 7, 2024
17 checks passed
@vcastellm vcastellm deleted the pullupstream/v0.5.0 branch February 7, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.