Skip to content

Commit

Permalink
feat: increase coverage
Browse files Browse the repository at this point in the history
  • Loading branch information
joanestebanr committed Sep 20, 2024
1 parent 84c4282 commit 2330590
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions sequencesender/txbuilder/banana_base_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package txbuilder_test

import (
"context"
"fmt"
"math/big"
"testing"

Expand Down Expand Up @@ -33,8 +34,15 @@ func TestBananaBaseNewSequenceEmpty(t *testing.T) {
seq, err := testData.sut.NewSequence(context.TODO(), nil, common.Address{})
require.NotNil(t, seq)
require.NoError(t, err)
// TODO check values
// require.Equal(t, lastAcc, seq.LastAccInputHash())
}

func TestBananaBaseNewSequenceErrorHeaderByNumber(t *testing.T) {
testData := newBananaBaseTestData(t)
testData.l1Client.On("HeaderByNumber", mock.Anything, mock.Anything).
Return(nil, fmt.Errorf("error"))
seq, err := testData.sut.NewSequence(context.TODO(), nil, common.Address{})
require.Nil(t, seq)
require.Error(t, err)
}

func TestBananaBaseNewBatchFromL2Block(t *testing.T) {
Expand Down Expand Up @@ -111,6 +119,11 @@ func TestBananaSanityCheck(t *testing.T) {
require.Error(t, err, "inside batchl2data max is 1 and counter is 1. The batchl2data is not included in counter")
}

func TestBananaSanityCheckNilSeq(t *testing.T) {
err := txbuilder.SequenceSanityCheck(nil)
require.Error(t, err, "nil sequence")
}

type testDataBananaBase struct {
rollupContract *mocks_txbuilder.RollupBananaBaseContractor
getContract *mocks_txbuilder.GlobalExitRootBananaContractor
Expand Down

0 comments on commit 2330590

Please sign in to comment.