-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Sequence Sender & Aggregator #10
Conversation
b74252c
to
21199b9
Compare
"github.com/0xPolygon/cdk/aggregator/types" | ||
"github.com/0xPolygon/cdk/dataavailability" | ||
"github.com/0xPolygon/cdk/etherman" | ||
"github.com/0xPolygon/cdk/log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should evaluate if we need to create a log package for wrapping the log dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the list that I obtained if things we want to change:
- Remove smartcontracts from etherman and rely on the repo
- Move the db dir to aggregator?
- Remove the state package as it's a DB abstraction on top of a single datastore and move to a KV based interface for each component
- Does the
log
package makes sense? Looks like there's a pattern here, I think we can use an interface to define a single logger and pass it to multiple components, reducing deps. - Looks like the DS dependency on sequence-sender depends on types declared in the
state
package
Aside from this some of the comments I think worth fixing before merging, wdyt?
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* feat: sequence sender and aggregator
Description
This is just a first iteration to get the base code into the repo. Further iterations will be needed.