Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sequence Sender & Aggregator #10

Merged
merged 17 commits into from
Jul 2, 2024
Merged

Conversation

ToniRamirezM
Copy link
Contributor

Description

  • Adds Sequence Sender
  • Adds Aggregator
  • Disables several linter rules

This is just a first iteration to get the base code into the repo. Further iterations will be needed.

@ToniRamirezM ToniRamirezM self-assigned this Jun 25, 2024
@ToniRamirezM ToniRamirezM marked this pull request as draft June 25, 2024 16:20
@ToniRamirezM ToniRamirezM marked this pull request as draft June 25, 2024 16:20
@vcastellm vcastellm changed the title Sequence Sender & Aggregator feat: Sequence Sender & Aggregator Jun 25, 2024
@ToniRamirezM ToniRamirezM marked this pull request as ready for review June 25, 2024 16:31
config/mainnetgenesis.go Outdated Show resolved Hide resolved
config/testnetgenesis.go Outdated Show resolved Hide resolved
encoding/encoding.go Outdated Show resolved Hide resolved
etherman/types/finalproofinputs.go Outdated Show resolved Hide resolved
etherman/types/sequence.go Outdated Show resolved Hide resolved
hex/hex.go Show resolved Hide resolved
metrics/api.go Outdated Show resolved Hide resolved
state/batch.go Show resolved Hide resolved
state/datastream.go Show resolved Hide resolved
@ToniRamirezM ToniRamirezM changed the base branch from main to develop June 27, 2024 13:05
"github.com/0xPolygon/cdk/aggregator/types"
"github.com/0xPolygon/cdk/dataavailability"
"github.com/0xPolygon/cdk/etherman"
"github.com/0xPolygon/cdk/log"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should evaluate if we need to create a log package for wrapping the log dependency

Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the list that I obtained if things we want to change:

  • Remove smartcontracts from etherman and rely on the repo
  • Move the db dir to aggregator?
  • Remove the state package as it's a DB abstraction on top of a single datastore and move to a KV based interface for each component
  • Does the log package makes sense? Looks like there's a pattern here, I think we can use an interface to define a single logger and pass it to multiple components, reducing deps.
  • Looks like the DS dependency on sequence-sender depends on types declared in the state package

Aside from this some of the comments I think worth fixing before merging, wdyt?

Copy link

sonarcloud bot commented Jul 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ToniRamirezM ToniRamirezM merged commit d299684 into develop Jul 2, 2024
2 of 4 checks passed
@ToniRamirezM ToniRamirezM deleted the feature/seq-sender branch July 2, 2024 14:47
Stefan-Ethernal pushed a commit that referenced this pull request Sep 17, 2024
* feat: sequence sender and aggregator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants