Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix release tags #114

Merged
merged 2 commits into from
Oct 9, 2024
Merged

ci: fix release tags #114

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56e8e8e
ci: fix release tags
vcastellm Oct 8, 2024
5615d92
ci: fix regex for release
vcastellm Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: Release

on:
push:
tags:
# run only against tags that follow semver (https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string)
- 'v[0-9]+.[0-9]+.[0-9]+*'
push:
tags:
- 'v*.*.*'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it is better to keep the previous regex, as it is more common way to name versions and star allows to have whatever suffix we want. WDYT?

- 'v*.*.*-*'

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
Expand Down Expand Up @@ -33,9 +33,6 @@ jobs:
TAGS: ${{ steps.meta.outputs.tags }}
VERSION: ${{ steps.meta.outputs.version }}
steps:
- name: validate tag
run: echo ${{ github.ref_name }} | grep -qE '^v[0-9]+\.[0-9]+\.[0-9]+(-rc\.[0-9]+)?$'

- name: Prepare
run: |
platform=${{ matrix.platform }}
Expand Down
Loading