feat: check SR from batch proofs matches the SR from the DS #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aggregator/prover/prover.go
Outdated
|
|
||
| var v [8]uint64 | ||
| var j = 0 | ||
| for i := 19; i < 19+8; i++ { |
There was a problem hiding this comment.
Extract 19 to some constant (probably also 8).
Comment on lines
+355
to
+356
| if err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
Nitpick
Suggested change
| if err != nil { | |
| log.Fatal(err) | |
| var ( | |
| v [8]uint64 | |
| j = 0 | |
| ) |
ToniRamirezM
force-pushed
the
feature/CheckSRFromBatchProof
branch
from
6d90a34
to
9420376
Compare
|
Stefan-Ethernal
approved these changes
Aug 8, 2024
Stefan-Ethernal
pushed a commit
that referenced
this pull request
Sep 17, 2024
* feat: check SR from batch proofs matches the SR from the DS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every time the aggregator gets a new batch proof from the prover, it checks that the resulting SR is the expected one, retrieved from the data stream. If the check fails, it fatals.
Until now, it was only checked for final proofs, it makes more sense to check at batch level, as some final proof would not be generated in case a SR mismatches.