Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to sequence_sender to work as Banana or Elderberry #16

Merged
merged 54 commits into from
Jul 26, 2024
Merged

feat: allow to sequence_sender to work as Banana or Elderberry #16

merged 54 commits into from
Jul 26, 2024

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Jul 17, 2024 •
edited
Loading

Description

You can configure sequence_sender to work as Banana or Elderberry

This are the major changes on code:

  • Decoupled contracts creating an abstranction layer
  • Etherman use the configured contract
  • Sequence Sender code have ifs for Validium (is abstracted on TxBuilder class)
  • The configuration of fork and IsValidiumMode have been moved to a common section on config file:
[Common]
IsValidiumMode = false
ContractVersions = "banana"

@joanestebanr joanestebanr self-assigned this Jul 17, 2024
@joanestebanr joanestebanr changed the base branch from main to CDK-260-sequence-sender-integrate-banana July 17, 2024 08:09
goran-ethernal
goran-ethernal reviewed Jul 22, 2024
View reviewed changes
etherman/contracts.go Outdated Show resolved Hide resolved
etherman/aggregator.go Show resolved Hide resolved
etherman/contracts/interfaces.go Outdated Show resolved Hide resolved
sequencesender/sequencesender_test.go Outdated Show resolved Hide resolved
sequencesender/txbuilder/banana_types.go Show resolved Hide resolved
@joanestebanr joanestebanr changed the title Allow to sequence_sender to work as Banana or Elderberry feat: allow to sequence_sender to work as Banana or Elderberry Jul 24, 2024
@vcastellm vcastellm closed this Jul 24, 2024
@vcastellm vcastellm reopened this Jul 24, 2024
@joanestebanr joanestebanr marked this pull request as ready for review July 25, 2024 10:47
goran-ethernal
goran-ethernal approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for minor comments LGTM

cmd/run.go Outdated Show resolved Hide resolved
translator/translator_impl.go Outdated Show resolved Hide resolved
dataavailability/datacommittee/datacommittee.go Outdated Show resolved Hide resolved
dataavailability/datacommittee/datacommittee.go Outdated Show resolved Hide resolved
etherman/contracts/interfaces.go Outdated Show resolved Hide resolved
sequencesender/sequencesender.go Outdated Show resolved Hide resolved
sequencesender/sequencesender.go Outdated Show resolved Hide resolved
sequencesender/sequencesender.go Outdated Show resolved Hide resolved
sequencesender/sequencesender.go Outdated Show resolved Hide resolved
sequencesender/txbuilder/banana_base.go Outdated Show resolved Hide resolved
Stefan-Ethernal
Stefan-Ethernal reviewed Jul 25, 2024
View reviewed changes
.github/workflows/test-e2e.yml Show resolved Hide resolved
dataavailability/datacommittee/datacommittee.go Outdated Show resolved Hide resolved
dataavailability/datacommittee/datacommittee.go Outdated Show resolved Hide resolved
dataavailability/datacommittee/datacommittee.go Outdated Show resolved Hide resolved
dataavailability/datacommittee/datacommittee.go Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
dataavailability/datacommittee/datacommittee_test.go Outdated Show resolved Hide resolved
joanestebanr and others added 15 commits July 25, 2024 15:54
@joanestebanr
PR comments
1fc99d7
@joanestebanr @Stefan-Ethernal
Update dataavailability/datacommittee/datacommittee.go
06aa68c 
Co-authored-by: Stefan Negovanović <[email protected]>
@joanestebanr
PR comments
af1640d
@joanestebanr @Stefan-Ethernal
Update Makefile
4979588 
Co-authored-by: Stefan Negovanović <[email protected]>
@joanestebanr @Stefan-Ethernal
Update dataavailability/datacommittee/datacommittee_test.go
19dab0c 
Co-authored-by: Stefan Negovanović <[email protected]>
@joanestebanr @Stefan-Ethernal
Update test/scripts/config_kurtosis_for_local_run.sh
f499b7f 
Co-authored-by: Stefan Negovanović <[email protected]>
@joanestebanr
PR comments
f1085b6
@joanestebanr @Stefan-Ethernal
Update test/config/test.kurtosis_template.toml
fddefb1 
Co-authored-by: Stefan Negovanović <[email protected]>
@joanestebanr
PR comments
95799d6
@joanestebanr
PR comments
f34765f
@joanestebanr
PR comments
14eb4fa
@joanestebanr
PR comments
8adc59e
@joanestebanr
PR comments
9c2e662
@joanestebanr @goran-ethernal
Update cmd/run.go
e3c3a59 
Co-authored-by: Goran Rojovic <[email protected]>
@joanestebanr
PR comments
098b503
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@joanestebanr joanestebanr merged commit 8b22abb into CDK-260-sequence-sender-integrate-banana Jul 26, 2024
5 of 7 checks passed
@vcastellm vcastellm deleted the feature/seq_sender-multi-fork branch July 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

@vcastellm vcastellm Awaiting requested review from vcastellm

Assignees

@joanestebanr joanestebanr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joanestebanr @vcastellm @Stefan-Ethernal @goran-ethernal