Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reorg detector #17

Merged
merged 11 commits into from
Jul 24, 2024
Merged

feat: Reorg detector #17

merged 11 commits into from
Jul 24, 2024

Conversation

goran-ethernal
Copy link
Collaborator

Description

This PR finishes the reorgdetector feature in cdk repo.

Fixes # (issue)

@goran-ethernal goran-ethernal changed the base branch from main to develop July 19, 2024 09:56
@goran-ethernal goran-ethernal changed the title Reorg detector feat: Reorg detector Jul 19, 2024
@goran-ethernal goran-ethernal marked this pull request as ready for review July 22, 2024 11:03
@goran-ethernal goran-ethernal self-assigned this Jul 22, 2024
reorgdetector/reorgdetector.go Outdated Show resolved Hide resolved
reorgdetector/reorgdetector.go Outdated Show resolved Hide resolved
reorgdetector/reorgdetector.go Outdated Show resolved Hide resolved
reorgdetector/reorgdetector.go Show resolved Hide resolved
reorgdetector/reorgdetector.go Outdated Show resolved Hide resolved
reorgdetector/reorgdetector.go Show resolved Hide resolved
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks if they make sense

reorgdetector/reorgdetector_test.go Outdated Show resolved Hide resolved
reorgdetector/reorgdetector_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpicks if they make sense

reorgdetector/reorgdetector.go Show resolved Hide resolved
reorgdetector/reorgdetector.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@goran-ethernal goran-ethernal merged commit a4bf5f8 into develop Jul 24, 2024
2 of 4 checks passed
@goran-ethernal goran-ethernal deleted the feat/reorg-detector branch July 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants