Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove sanity check #178

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: remove sanity check #178

merged 1 commit into from
Nov 12, 2024

Conversation

ToniRamirezM
Copy link
Contributor

@ToniRamirezM ToniRamirezM commented Nov 12, 2024 •
edited
Loading

Description

Removes unneeded sanity check

@ToniRamirezM ToniRamirezM requested review from joanestebanr and a team November 12, 2024 10:11
@ToniRamirezM ToniRamirezM self-assigned this Nov 12, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
25.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

joanestebanr
joanestebanr approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@joanestebanr joanestebanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sanity check is no longer required because the l1InfoRootIndex is comming from batchl2data and it's same place that is checked. The sanity sanityCheck goal was to check that the batch data comming from Data-stream was right

@ToniRamirezM ToniRamirezM merged commit b480dd4 into release/v0.4.0 Nov 12, 2024
10 checks passed
@ToniRamirezM ToniRamirezM deleted the feature/removeSanitycheck branch November 12, 2024 10:35
ToniRamirezM added a commit that referenced this pull request Nov 12, 2024
@ToniRamirezM
feat: remove sanity check (#178)
8c3dbce
@ToniRamirezM ToniRamirezM mentioned this pull request Nov 12, 2024
Merged
ToniRamirezM added a commit that referenced this pull request Nov 12, 2024
@ToniRamirezM
feat: remove sanity check (#178) (#179)
05f8290
joanestebanr added a commit that referenced this pull request Nov 12, 2024
@joanestebanr @goran-ethernal
@rachit77 @ToniRamirezM
feat: include aggsender to release 0.4.0 (#181)
0ed309e 
* feat: unpack and log agglayer errors (#158)

* feat: unpack and log agglayer errors

* feat: agglayer error unpacking

* fix: lint and UT

* feat: epoch notifier (#144)

- Send certificates after a percentage of epoch
- Require epoch configuration to AggLayer
- Change config of `aggsender` adding: `BlockFinality` and `EpochNotificationPercentage`

* refact: GetSequence method (#169)

* feat: remove sanity check (#178) (#179)

---------

Co-authored-by: Goran Rojovic <[email protected]>
Co-authored-by: Rachit Sonthalia <[email protected]>
Co-authored-by: Toni Ramírez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanestebanr joanestebanr joanestebanr approved these changes

Assignees

@ToniRamirezM ToniRamirezM

Labels
seqsender
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ToniRamirezM @joanestebanr