Feature/agg oracle #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaubennassar
force-pushed
the
feature/aggOracle
branch
from
794e0dd
to
f6bf0ad
Compare
rachit77
approved these changes
Jul 31, 2024
sync/common.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| RetryAfterErrorPeriod = time.Second * 10 |
There was a problem hiding this comment.
Maybe is better to be able to configure this values
| if len(blocks) == 0 || blocks[len(blocks)-1].Num < l.BlockNumber { | ||
| b := d.getBlockHeader(ctx, l.BlockNumber) | ||
| blocks = append(blocks, EVMBlock{ | ||
| EVMBlockHeader: EVMBlockHeader{ |
There was a problem hiding this comment.
Why are you creating an empty block?
There was a problem hiding this comment.
if this block number is not yet added in the form of EVMBlock into blocks, we need to create it and prepare this new block so the appender can append events into it. Note that we only do this operation when there are relevant blocks, and the block is not yet added into blocks
|
Stefan-Ethernal
approved these changes
Aug 1, 2024
joanestebanr
approved these changes
Aug 1, 2024
Stefan-Ethernal
added a commit
that referenced
this pull request
Sep 17, 2024
* implementation completed, missing tests * WIP * WIP * WIP * sync refactor * decouple sync processors from EVM * Add CLI for aggOracle * WIP * wip * WIP * start reorg detector * fix docker * pass test with docker * add TODO * go mod tidy * Add PR review suggestions from Stefan-Ethernal * fix UTs * Add PR review suggestions from joanestebanr --------- Co-authored-by: Stefan Negovanović <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.