Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unittest for multi-fork support #25

Merged
merged 11 commits into from
Aug 1, 2024
Merged

Add unittest for multi-fork support #25

merged 11 commits into from
Aug 1, 2024

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Jul 30, 2024 •
edited
Loading

  • Add unittest for new code under sequencesender/txbuilder (> 80%)
  • Improved contracts base clase and is no longer needed Contract()
  • Removed param sender for txBuilder.BuildSequenceBatchesTx because it use the From from bind.TransactOpts variable

@joanestebanr joanestebanr self-assigned this Jul 30, 2024
@joanestebanr joanestebanr marked this pull request as ready for review July 31, 2024 11:31
@joanestebanr
Copy link
Contributor Author

The unittest reach 81,8%

$ make test-seq_sender 
(...)
ok      github.com/0xPolygon/cdk/sequencesender/txbuilder       1.107s  coverage: 81.8% of statements
(...)

vcastellm
vcastellm reviewed Aug 1, 2024
View reviewed changes
Makefile Show resolved Hide resolved
vcastellm
vcastellm approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
27.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@joanestebanr joanestebanr merged commit 12d1e3f into develop Aug 1, 2024
4 of 7 checks passed
@joanestebanr joanestebanr deleted the feature/cdk393-unittest branch August 1, 2024 15:01
Stefan-Ethernal pushed a commit that referenced this pull request Sep 17, 2024
@joanestebanr @Stefan-Ethernal
Add unittest for multi-fork support (#25)
b5f3e53 
- Add unittest for new code under sequencesender/txbuilder (> 80%)
- Improved contracts base clase and is no longer needed Contract()
- Removed param sender for txBuilder.BuildSequenceBatchesTx because it use the From from bind.TransactOpts variable
- Require just 1 verified batch to pass e2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@arnaubennassar arnaubennassar arnaubennassar approved these changes

Assignees

@joanestebanr joanestebanr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joanestebanr @vcastellm @arnaubennassar