-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/exittree #27
Feature/exittree #27
Conversation
Feature/rollup exit tree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some comments. Haven't finished reviewing appendable and updateable tree.
bf81bf4
to
c9c63b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we have a UT failing. Might be good to check what is going on.
Quality Gate failedFailed conditions |
* implementation completed, missing tests * WIP * WIP * WIP * sync refactor * decouple sync processors from EVM * Add CLI for aggOracle * WIP * wip * WIP * start reorg detector * fix docker * pass test with docker * add TODO * go mod tidy * Implement base addLeaf * pass test vectors * fix UT * Add PR review suggestions from Stefan-Ethernal * fix UTs * Add PR review suggestions from Stefan-Ethernal * fix datacommittee_test deploying proxy contract * fix UTs * WIP * WIP * abstract tree * Fix UTs * Add PR review suggestions from joanestebanr * Fix evmdownloader problems * refactor tree add and rollback to be atomic * simplify l1infotree * implementation done, test WIP * pass E2E test * remove outdated coment * make test shorter * Add coments * Apply requests from Stefan-Ethernal and goran-ethernal * increase sleep to pass UT * reduce test iterations --------- Co-authored-by: Stefan Negovanović <[email protected]> Co-authored-by: joanestebanr <[email protected]>
localbridgesync
tobridgesync
since now it will sync both L1 & L2 bridgestree
from the bridge processor, as now this tree will be reused by many syncers. Although the file appears to be new on theFiles changed
the logic is pretty much the same, just separated the treerollup exit tree
ctx
on the Reorg and ProcessBlock functions for the processorsl1infotreesync/e2e_test.go
. Note that theAppendOnlyTree
was used previously in thelocalbridgesync