Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: seq sender sanity check l1infotree #86

Merged
merged 5 commits into from
Sep 20, 2024
Merged

feat: seq sender sanity check l1infotree #86

merged 5 commits into from
Sep 20, 2024

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Sep 19, 2024 •
edited
Loading

Description

When a sequence is build it checks that the L1InfoTreeCount set include the indexes inside batchL2data of all batches conforming the sequence

@joanestebanr joanestebanr self-assigned this Sep 19, 2024
@joanestebanr joanestebanr changed the base branch from main to develop September 19, 2024 11:13
@joanestebanr joanestebanr changed the title Feature/seq sender sanity check l1infotree Feat: seq sender sanity check l1infotree Sep 19, 2024
@joanestebanr joanestebanr changed the title Feat: seq sender sanity check l1infotree feat: seq sender sanity check l1infotree Sep 19, 2024
@joanestebanr joanestebanr marked this pull request as ready for review September 19, 2024 12:55
Stefan-Ethernal
Stefan-Ethernal approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, left a couple of comments to consider.

sequencesender/sequencesender.go Show resolved Hide resolved
sequencesender/txbuilder/banana_types.go Show resolved Hide resolved
sequencesender/txbuilder/banana_types.go Outdated Show resolved Hide resolved
sequencesender/txbuilder/banana_types.go Show resolved Hide resolved
sequencesender/sequencesender.go Outdated Show resolved Hide resolved
sequencesender/sequencesender.go Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vcastellm
vcastellm approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joanestebanr joanestebanr merged commit 681c987 into develop Sep 20, 2024
9 checks passed
@joanestebanr joanestebanr deleted the feature/seq_sender-sanity_check_l1infotree branch September 20, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@goran-ethernal goran-ethernal goran-ethernal approved these changes

Assignees

@joanestebanr joanestebanr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joanestebanr @vcastellm @Stefan-Ethernal @goran-ethernal