POC Approach 1 ( No Wrapping and using ERC20Predicate contract ) #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drinkcoffee
reviewed
Jul 19, 2023
| @@ -74,6 +76,10 @@ contract RootERC20Predicate is Initializable, IRootERC20Predicate { | |||
| _deposit(rootToken, msg.sender, amount); | |||
| } | |||
|
|
|||
| function depositNativeTo(address receiver) external payable { | |||
There was a problem hiding this comment.
Add to IRootERC20Predicate and have documentation indicating this doc inherits from the interface
There was a problem hiding this comment.
I can clean up docs and more if we feel like this is the 'overall' right approach we want to take @drinkcoffee . ATM it's just PoC level code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to this issue, this is a PoC of 1 approach. Should not be merged.
#299
Overall, I'm not very happy with the approach the way the code looks when this approach is taken. it feels very hacky and like trying to fit a square peg in a round hole.