Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: low-info #400

Merged
merged 10 commits into from
Dec 1, 2023
Merged

fix: low-info #400

merged 10 commits into from
Dec 1, 2023

Conversation

ZeroEkkusu
Copy link
Member

@ZeroEkkusu ZeroEkkusu commented Oct 3, 2023 •
edited
Loading

To-do: Reorg a few things Done

@ZeroEkkusu ZeroEkkusu marked this pull request as draft October 20, 2023 11:37
@ZeroEkkusu ZeroEkkusu marked this pull request as ready for review October 20, 2023 13:48
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6588590257

  • 20 of 30 (66.67%) changed or added relevant lines in 30 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 78.365%
Changes Missing Coverage Covered Lines Changed/Added Lines %
contracts/child/ChildERC1155PredicateAccessList.sol 0 1 0.0%
contracts/child/ChildERC20PredicateAccessList.sol 0 1 0.0%
contracts/child/ChildERC721PredicateAccessList.sol 0 1 0.0%
contracts/child/RootMintableERC1155PredicateAccessList.sol 0 1 0.0%
contracts/child/RootMintableERC20PredicateAccessList.sol 0 1 0.0%
contracts/child/RootMintableERC721PredicateAccessList.sol 0 1 0.0%
contracts/child/validator/RewardPool.sol 0 1 0.0%
contracts/child/validator/ValidatorSet.sol 0 1 0.0%
contracts/root/staking/CustomSupernetManager.sol 0 1 0.0%
contracts/root/staking/StakeManager.sol 0 1 0.0%
Totals Coverage Status
Change from base Build 6312065521: -0.1%
Covered Lines: 1304
Relevant Lines: 1609
💛 - Coveralls

@ZeroEkkusu ZeroEkkusu merged commit 0df6120 into dev Dec 1, 2023
5 of 7 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 12 Code Smells

No Coverage information No Coverage information
50.2% 50.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DhairyaSethi DhairyaSethi DhairyaSethi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZeroEkkusu @coveralls @DhairyaSethi