-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking PC validity performance improvement #89
Checking PC validity performance improvement #89
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 88.53% 89.48% +0.94%
==========================================
Files 7 7
Lines 1527 1502 -25
==========================================
- Hits 1352 1344 -8
+ Misses 134 119 -15
+ Partials 41 39 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM neat
Description
This PR include changes related to validation of PreparedCertificate messages. Earlier there were separate functions for checking height,round,senders and proposal hash. Now they are merged into AreValidPCMessages to avoid iterating 5 times instead of once. We decided to do this because the code will still remain readable.
Changes include
Checklist