Skip to content

Commit

Permalink
Merge pull request #448 from jhkimqd/jihwan/fix-remote-pr-ci
Browse files Browse the repository at this point in the history
refactor: change behavior of ci when external pr raised
  • Loading branch information
jhkimqd authored Jan 31, 2025
2 parents 9833897 + cf88a48 commit f8d9e68
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/tests/agglayer-sp1-key.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@ deployment_stages:
deploy_cdk_bridge_ui: false

args:
agglayer_prover_sp1_key: ""
agglayer_prover_sp1_key: null
agglayer_prover_network_url: https://rpc.production2.succinct.tools
zkevm_contracts_image: leovct/zkevm-contracts:v9.0.0-rc.5-pp-fork.12

consensus_contract_type: pessimistic
erigon_strict_mode: false
gas_token_enabled: false
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ jobs:
# Step to handle when the SP1_PRIVATE_KEY secret is available.
- name: Replace Agglayer SP1 Prover Key with Github Secrets
run: |
sed -i "s/agglayer_prover_sp1_key: \"\"/agglayer_prover_sp1_key: \"${{ secrets.SP1_PRIVATE_KEY }}\"/" ./.github/tests/agglayer-sp1-key.yml
sed -i "s/agglayer_prover_sp1_key: null/agglayer_prover_sp1_key: \"${{ secrets.SP1_PRIVATE_KEY }}\"/" ./.github/tests/agglayer-sp1-key.yml
# This step will only execute if the necessary secrets are available, preventing failures
# on pull requests from forked repositories.
if: ${{ env.agglayer_prover_sp1_key && env.agglayer_prover_sp1_key != '' }}
Expand Down

0 comments on commit f8d9e68

Please sign in to comment.