Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate pool manager into kurtosis-cdk #205

Merged
merged 5 commits into from
Aug 8, 2024
Merged

feat: integrate pool manager into kurtosis-cdk #205

merged 5 commits into from
Aug 8, 2024

Conversation

jhkimqd
Copy link
Collaborator

@jhkimqd jhkimqd commented Aug 5, 2024 •
edited
Loading

Description

This PR integrates the zkevm-pool-manager into Kurtosis-CDK.

When the pool-manager server receives a send_rawTransaction request, it stores the tx info in the pool-manager DB and resends the tx to the Erigon-Sequencer (this is done by the sender workers, by default we have 5). After this the pool-manager monitors the tx and updates its state (this is done by monitor workers, by default we have 5). The monitor workers use the L2NodeURL to query for txs receipts

Testing

There are two steps for verification:

  • Tx appears in the pool.transaction table
  • The tx needs to be processed and confirmed by the Erigon-Sequencer

Both has been tested on a local setup:

  1. Initial empty pool_manager_db
    Screenshot from 2024-08-05 21-51-55

  2. Sent load with polycli loadtest
    Screenshot from 2024-08-05 21-53-55

  3. pool_manager_db.transaction table being populated
    Screenshot from 2024-08-05 21-54-06

@jhkimqd
style: lint
aebc790 
Signed-off-by: Ji Hwan <[email protected]>
@jhkimqd jhkimqd enabled auto-merge August 5, 2024 13:33
@jhkimqd jhkimqd disabled auto-merge August 5, 2024 13:33
praetoriansentry
praetoriansentry approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@praetoriansentry praetoriansentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome lgtm.

I think we should probably wait to merge this until @vcastellm handles #193

@jhkimqd jhkimqd merged commit 06a0c98 into 0xPolygon:main Aug 8, 2024
4 of 5 checks passed
vcastellm
vcastellm reviewed Aug 8, 2024
View reviewed changes
lib/zkevm_pool_manager.star
"/etc/pool-manager": Directory(artifact_names=[config_artifact]),
},
entrypoint=["/bin/sh", "-c"],
# cmd=["run", "--cfg", "/app/pool-manager-config.toml"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove?

vcastellm
vcastellm reviewed Aug 8, 2024
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice work here @jhkimqd 🎩 Late LGTM just a small comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcastellm vcastellm vcastellm left review comments

@praetoriansentry praetoriansentry praetoriansentry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhkimqd @vcastellm @praetoriansentry