-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support legacy zkevm-node and new zkevm sequence senders and aggregators #234
base: main
Are you sure you want to change the base?
feat: support legacy zkevm-node and new zkevm sequence senders and aggregators #234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and lgtm.
Might be worth noting somewhere that the legacy configs may not work with CDK-Erigon configs. e.g. aggregator_sequence_sender_type
and sequencer_type
had to be both zkevm
to work on my test.
I think we should aim to cover scenarios 1, 2, 4, 7 and 8. I updated the CI jobs to test that. |
This PR also cleans up some parts of the CDK central environment (e.g. how sequencer is deployed, how aggregator / sequence sender is deployed, etc.). The central RPC deployed will be of the same type as the sequencer. For example, if |
62f6b8a
to
5aa6671
Compare
Update before I leave for a few days: every scenario work except the one with cdk-erigon as the sequence and the new zkevm components (zkevm-sequence-sender and zkevm-aggregator). Batches are being virtualized but not verified. I tried to bump the images but it looks like there is still an issue with the aggregator. |
This reverts commit a104309.
…-aggregator-and-sequence-sender
Description
In #193, we introduced cdk-node as the default sequence sender / aggregator component for the CDK stack. In this effort, we removed support for the legacy zkevm-node sequence sender and aggregator as well as the new zkevm components, zkevm-sequence-sender and zkevm-aggregator. However, this is something we still need to test.
This PR introduces a new flag
sequence_sender_aggregator_type
to specify the type of sequence sender and aggregator to deploy. There are 3 options:cdk
: Use the new cdk-node.new-zkevm
: Use the new zkevm components: zkevm-sequence-sender and zkevm-aggregator.legacy-zkevm
: Use the legacy zkevm-node sequence sender and aggregator.The following diagram describes what kurtosis-cdk currently deploys (only for the central environment).
And the following diagram represents what kurtosis-cdk will be able to deploy with this new change.
The
deploy
workflow has been updated to test different scenarios listed under.github/tests
. For example, the scenarioerigon-sequencer-cdk-stack-cdk-validium-da.yml
will deploy a devnet with an L1 and a CDK L2 with erigon as the sequencer, the cdk-node as the sequence sender / aggregator and the chain will be a CDK validium.References (if applicable)
https://0xpolygon.slack.com/archives/C06M06XR5A4/p1724233695796189