Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add persistence e2e test. #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

0xSasaPrsic
Copy link
Contributor

@0xSasaPrsic 0xSasaPrsic commented May 5, 2022

Persistence issue test where nodes can insert different proposal for the same sequence.
Cluster of 5 nodes: A_0, A_1, A_2, A_3, A_4
Flow map defined for the round 0:
A_0 -> A_0, A_1, A_2, A_3
A_1 -> A_1, A_2, A_3
A_2 -> A_0, A_2
A_3 -> A_0, A_2

In round 0 node proposer A_0 receives enough commit messages from other nodes defined in the flow map and inserts a proposal.
Node A_3 in round 0 gets locked.
Node A_2 after receiving enough commit messages fails to insert proposal locally and unlocks the proposal and triggers round change.
In round 0 nodes A_1 and A_4 do not receive enough messages on time and trigger round change.
At this point: node A_0 has inserted proposal, node A_1 is not locked, node A_2 is not locked (unlocked because insert failed), node A_3 is locked and node A_4 did not receive any message
After moving to round 1 proposer A_1 creates a new proposal which then is propagated through the network
and gets inserted since there is enough commit messages from nodes A_1, A_2 and A_4
which is different from the proposal inserted in round 0.

@0xSasaPrsic 0xSasaPrsic force-pushed the POS3-143/e2e_persistance branch 4 times, most recently from a2d58e6 to 866c8b8 Compare May 5, 2022 20:09
@0xSasaPrsic 0xSasaPrsic marked this pull request as ready for review May 6, 2022 07:12
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@7320bcd). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage        ?   91.97%           
=======================================
  Files           ?        3           
  Lines           ?      835           
  Branches        ?        0           
=======================================
  Hits            ?      768           
  Misses          ?       62           
  Partials        ?        5           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants