-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for authorization header #187
Draft
praetoriansentry
wants to merge
14
commits into
main
Choose a base branch
from
jhilliard/rpc-auth-header
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
10b371d
concurrent processing of get blocks. batches by 50 default
gatsbyz 4cbd12b
fix error
gatsbyz 76e155b
lock on error value
gatsbyz 2ef1695
leo comments
gatsbyz 86d0ed7
add lock
gatsbyz 318d9ba
block info
gatsbyz ea34fe4
Update cmd/monitor/monitor.go
gatsbyz f849992
final changes to monitor
gatsbyz a4b7a45
feat: adding an auth token option for monitor
praetoriansentry 1d73a51
feat: switching to generic headers
praetoriansentry e3bf551
fix: https://github.com/maticnetwork/polygon-cli/pull/181#pullrequest…
praetoriansentry dc247e5
Merge branch 'main' into jesse/monitor-process-batch-concurrently
praetoriansentry 2e25fbb
Merge branch 'jesse/monitor-process-batch-concurrently' into jhilliar…
praetoriansentry 7e8d80a
feat: adding header option to loadtest
praetoriansentry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -347,7 +347,15 @@ func runLoadTest(ctx context.Context) error { | |
} | ||
|
||
// Dial the Ethereum RPC server. | ||
rpc, err := ethrpc.DialContext(ctx, *inputLoadTestParams.RPCUrl) | ||
var rpc *ethrpc.Client | ||
var err error | ||
if inputLoadTestParams.ParsedHTTPHeaders == nil { | ||
log.Trace().Msg("No HeadersAdding custom headers") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit, spacing: No Headers. Adding custom headers. |
||
rpc, err = ethrpc.DialContext(ctx, *inputLoadTestParams.RPCUrl) | ||
} else { | ||
log.Trace().Msg("Adding custom headers") | ||
rpc, err = ethrpc.DialOptions(ctx, *inputLoadTestParams.RPCUrl, ethrpc.WithHTTPAuth(util.GetHTTPAuth(inputLoadTestParams.ParsedHTTPHeaders))) | ||
} | ||
if err != nil { | ||
log.Error().Err(err).Msg("Unable to dial rpc") | ||
return err | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for clarity: if user needs to pass multiple headers, what is the recommended / valid format? pass multiple -H flags to polycli cmd, or, single -H with comma separated set of headers?