Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: break from infinite loop when txn receipt not retrieved #376

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: break from infinite loop when txn receipt not retrieved #376

wants to merge 4 commits into from

Conversation

jhkimqd
Copy link
Contributor

@jhkimqd jhkimqd commented Sep 19, 2024 •
edited
Loading

Description

This PR replaces the return with a break to stop the infinite loop in the case where the txn receipts are not retrieved. It is a measure to stop the process, but the root cause - BatchCallContext not working for batches with many txns still needs to be further investigated.

The BatchCallContext failing to unmarshal txns is now also fixed.

Testing

break out of infinite loop

image

unmarshal for larger batches working

Screenshot from 2024-09-20 13-33-13

@jhkimqd jhkimqd marked this pull request as draft September 20, 2024 02:59
auto-merge was automatically disabled September 20, 2024 02:59

Pull request was converted to draft

@jhkimqd jhkimqd marked this pull request as ready for review September 20, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praetoriansentry praetoriansentry Awaiting requested review from praetoriansentry

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jhkimqd