chore: introduce sub Makefiles
#83
Conversation
leovct
force-pushed
the
leovct/chore-remove-geth-and-avail-targets
branch
from
ab56b40
to
b63b790
Compare
| @@ -0,0 +1,24 @@ | |||
| ##@ Clients | |||
There was a problem hiding this comment.
The main Makefile should only contain targets related to build, install and test to keep it simple and easier to maintain.
Then where do we store other targets that may be useful? I suggest that we make use of sub Makefiles such as scripts/clients.mk and scripts/lint.mk.
We can import the targets from these files into the main Makefile using include scripts/clients.mk. This is useful if you still want to show these targets in the main help.
It's also possible to call a target from a sub Makefile without going through the main Makefile, for example $ make -f scripts/clients.mk geth.
@praetoriansentry wdyt?
There was a problem hiding this comment.
I like it. I would just confirm that your changes don't impact any of the github work flows / ci.
leovct
changed the title
avail and gethMakefiles
leovct
force-pushed
the
leovct/chore-remove-geth-and-avail-targets
branch
from
488d8d7
to
cfe1a43
Compare
|
PR rebased with latest changes. |
Related to @praetoriansentry's comment on #82
JIRA Ticket