Jesse/loadtest legacy mode #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leovct
reviewed
Jun 27, 2023
leovct
reviewed
Jun 28, 2023
|
🙏 |
praetoriansentry
previously requested changes
Jun 28, 2023
gatsbyz
force-pushed
the
jesse/loadtest-legacy-mode
branch
from
577534e
to
2372100
Compare
leovct
reviewed
Jun 29, 2023
leovct
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
lgtm, great work @gatsbyz :)
I tested against geth and didn't see any perf issues but let's wait for John's review :)
# standard
$ ./out/polycli loadtest --verbosity 700 --chain-id 1337 --concurrency 1 --requests 8000 --rate-limit 2000 --mode t http://127.0.0.1:8545
10:04AM INF * Results
10:04AM INF Samples samples=8000
10:04AM INF Start startTime=2023-06-29T10:04:42+02:00
10:04AM INF End endTime=2023-06-29T10:04:46+02:00
10:04AM INF Mean Wait meanWait=0.00042218980237499946
10:04AM INF Num errors numErrors=0
10:04AM INF Finished
# legacy
$ ./out/polycli loadtest --verbosity 700 --chain-id 1337 --concurrency 1 --requests 8000 --rate-limit 2000 --mode t --legacy http://127.0.0.1:8545
10:05AM INF * Results
10:05AM INF Samples samples=8000
10:05AM INF Start startTime=2023-06-29T10:05:02+02:00
10:05AM INF End endTime=2023-06-29T10:05:06+02:00
10:05AM INF Mean Wait meanWait=0.0004291837611249989
10:05AM INF Num errors numErrors=0
10:05AM INF Finished
* auto determine chain ID * chain id 0 * chain id command * Update cmd/loadtest/loadtest.go Co-authored-by: John Hilliard <[email protected]> * fix: minor duplicate log messages --------- Co-authored-by: John Hilliard <[email protected]>
* 1559 aware monitor variables * put back * add to struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.