[DVT-819][DVT-903] Use p2p.Server and refactor #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhd-vu
changed the title
minhd-vu
force-pushed
the
minhd-vu/set-enode-private-key
branch
from
44654e4
to
b503cfe
Compare
minhd-vu
changed the title
minhd-vu
changed the title
praetoriansentry
approved these changes
Aug 16, 2023
| @@ -36,7 +37,7 @@ var ( | |||
| var CrawlCmd = &cobra.Command{ | |||
| Use: "crawl [nodes file]", | |||
| Short: "Crawl a network on the devp2p layer and generate a nodes JSON file.", | |||
| Long: "If no nodes.json file exists, run `echo \"{}\" >> nodes.json` to get started.", | |||
| Long: "If no nodes.json file exists, it will be created.", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--nat,--dial-ratio, etc. have been added--key-fileflag which takes in a private key file so that the enodes are constant and not generated each time--key-fileflag is provided but the file doesn't exist it will generate a new filenodes.jsonfile format, it's now just:[ "enode://f11b3c44b6d85975529f8e1eccbcc0fd9b66deb7af1a40c90f0cd9c56b1868ceba431c1d71bd42e2ca8b45d9a785aafd253f29c7ff397a3fbb23b9249cc2db4f@143.244.63.70:30010", "enode://6cd4797e751354e48797f01aa33ca9361a096ee2f74668ddfa1dd7e50f5ba7ed7502539294e9af0879e85272e75983245683966898c49d6464c2d2b8d88b3a4e@5.161.43.211:30303", "enode://8a3447dd183f6a2f06b75446b1e72fb6d33b328d96af463944d5f48edc3174bc1ccaf71c7ba02105c394c20b5776ea424c4b2913b16a64b96501c27de4ab903e@54.209.35.7:30303" ]This is consistent across the
ping,crawl, andservercommands. The advantage of this is that it can be placed directly into abor'sdatadiras astatic-nodes.jsonfile. Additionally, the extra fields from thecrawlcommand will never be utilized.Jira / Linear Tickets
Testing