Merge pull request #2113 from 0xPolygon/hosted/DEVOPS-3370-nginx-fix-…

…for-invalid-url Deployment fix for invalid url to return 404
0xPolygon · Oct 14, 2024 · 3bbd8aa · 3bbd8aa
2 parents f8dccb9 + 2c4c955
commit 3bbd8aa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/Dockerfile.review b/Dockerfile.review
@@ -5,4 +5,4 @@ COPY app /app
 
 WORKDIR /app
 EXPOSE 80
-CMD ["nginx", "-g", "daemon off;"]
+CMD ["nginx", "-g", "daemon off;"]
diff --git a/build_branches.py b/build_branches.py
@@ -160,7 +160,7 @@ def update_nginx_config(pr_numbers, parsed_env):
     for pr_number in pr_numbers:
         location_block = f"""location /{pr_number} {{
             alias /app/{pr_number};
-            try_files $uri $uri/ /index.html;
+            try_files $uri $uri/ =404;
             error_page 404 /404.html;
         }}
         """

diff --git a/nginx.conf b/nginx.conf
@@ -15,10 +15,11 @@ http {
         listen 80;
 
         #REPLACE_APPS
+
         location / {
-            alias /app/#environment/;
+            root /app/#environment;
             index index.html;
-            try_files $uri $uri/ /index.html;
+            try_files $uri $uri/ /404.html;
             error_page 404 /404.html;
         }
     }