-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RELEASE ENVIRONMENT: DO NOT MERGE #1562
Conversation
… cdk/ares_components
… cdk/ares_components
… cdk/ares_components
… cdk/high-level
… hosted/cdk-fep
… cdk/ares_components
… cdk/ares_components
… hosted/cdk-fep
adding CLI to menu
Quality Gate passedIssues Measures |
|
||
- Modularity: CDK modular components allow developers to easily customize their L2 environment and build a chain that meets their specific needs. | ||
The power of zero-knowledge technology is seen in enabling chains to achieve trustless finality, where chain users do not have to dependent on a few individuals to confirm finality of their transactions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The power of zero-knowledge technology is seen in enabling chains to achieve trustless finality, where chain users do not have to dependent on a few individuals to confirm finality of their transactions. | |
The power of zero-knowledge technology is seen in enabling chains to achieve trustless finality, where chain users do not have to be dependent on a few individuals to confirm finality of their transactions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I close this suggestion please @vcastellm and you could review instead the PR for the overview: #1586
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the suggestions are in the PR now :)
WDYT about moving the |
|
||
!!! important | ||
|
||
For specific release tags, please reference the [version matrix document](https://www.notion.so/polygontechnology/version-matrix.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this URL for the version matric document publicly available? I wasn't able to open it, so probably double-check is the URL correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doc shouldn't be in this environment. Apologies.
| Prover | [zkevm-prover](https://github.com/0xPolygonHermez/zkevm-prover) | [zkevm-prover](https://github.com/0xPolygonHermez/zkevm-prover) | Same code for both - wip | | ||
| Data streamer | [zkevm-data-streamer](https://github.com/0xPolygon/zkevm-data-streamer) | [zkevm-data-streamer](https://github.com/0xPolygon/zkevm-data-streamer) | Same code for both | | ||
| DA Layer | None | [cdk-data-availability](https://github.com/0xPolygon/cdk-data-availability) | | | ||
| Contracts | [zkevm-contracts](https://github.com/0xPolygonHermez/zkevm-contracts) | [zkevm-contracts](https://github.com/0xPolygonHermez/zkevm-contracts) | Same code for both: 8.0.0-rc.2-fork.12 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to specify the exact version of the contracts, since we are not doing so for the other components (for that purpose, we have the version compatibility matrix AFAIK).
| Contracts | [zkevm-contracts](https://github.com/0xPolygonHermez/zkevm-contracts) | [zkevm-contracts](https://github.com/0xPolygonHermez/zkevm-contracts) | Same code for both: 8.0.0-rc.2-fork.12 | | |
| Contracts | [zkevm-contracts](https://github.com/0xPolygonHermez/zkevm-contracts) | [zkevm-contracts](https://github.com/0xPolygonHermez/zkevm-contracts) | Same code for both | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...this doc slipped in by accident and shouldn't be here. Apologies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WDYT?
- Consider adding some labels to the arrows between the
Bridge service
and theAgglayer components
as well as theZKEVM contracts
and theAgglayer components
. - The
cli
probably should be linked with the other components in the system (otherwise we can probably remove it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding these to my notes 👍
- Engineers use a CLI tool to manage the backend components, installing and initializing various modes of operation, such as validium versus rollup for example. | ||
- The CDK Erigon RPC sends transactions to the CDK Erigon sequencer which sequences transactions batches. | ||
- The CDK Erigon sequencer puts the transaction batches into the data streamer. | ||
- The data streamer streams data to the sequencer sender (validium mode) and the aggregator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that (validium mode)
can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding to my notes, closing this PR now
- The CDK Erigon sequencer puts the transaction batches into the data streamer. | ||
- The data streamer streams data to the sequencer sender (validium mode) and the aggregator. | ||
- The sequencer sender sequences batches into the L1 smart contract domain and persists data into DAC nodes for validium mode operations. | ||
- The aggregator sends batches to the prover and receives proofs in return. It then aggregates the proofs into batches before submitting them to the L1 domain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to Agglayer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @joanestebanr I'll add this to my notes, thank you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we will say to AggLayer
in the next release but will check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joanestebanr shouldn't we say it as ?
The aggregator sends batches to the prover and receives proofs in return. It then aggregates the proofs into batches before submitting them to the Agglayer or L1 depending on the chosen settlement layer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add your comments to the respective PR. I will make a note of this suggestion.
In Local deployment guide document:
|
Hi Stefan, thanks for the question. Actually we house all images in the one folder and the reason for that is in case we ever had a lot of non-textual content, maybe videos, etc we might take the decision to host it externally, for example, and it would be easy to implement. |
We're leaving the mock prover in for the local start up guide. The production guide will have more details on connecting a real prover. |
Hosted url: docs-dev.polygon.technology/1562
This PR maintains a hosted environment for all the CDK FEP docs.