Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardforking example #1567

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

igorcrevar
Copy link
Contributor

@igorcrevar igorcrevar commented May 30, 2023

Description

Example for EVM-607

There are two new forks:

  • MyFirstFork - enabled from the block 10
  • MySecondFork - enabled from the block 20

We have changed Extra structure to behave exactly like before until block 10
and to Marshall/Un-marshal/Validate one more field from block 10 until block 20
and to Marshall/Un-marshal/Validate one more field from block 20 until the end of the time

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@igorcrevar igorcrevar changed the base branch from develop to feature/forking_poc May 30, 2023 11:38
@igorcrevar igorcrevar force-pushed the feature/forking_poc_with_example branch 3 times, most recently from db3a789 to edb3052 Compare May 30, 2023 13:45
@igorcrevar igorcrevar mentioned this pull request May 30, 2023
11 tasks
@igorcrevar igorcrevar force-pushed the feature/forking_poc_with_example branch 8 times, most recently from cf83dd5 to 592dbf8 Compare June 1, 2023 08:50
@igorcrevar igorcrevar changed the base branch from feature/forking_poc to develop June 2, 2023 11:16
@igorcrevar igorcrevar force-pushed the feature/forking_poc_with_example branch 2 times, most recently from 7cc9bd1 to 32b3c56 Compare June 2, 2023 11:20
@igorcrevar igorcrevar force-pushed the feature/forking_poc_with_example branch from 32b3c56 to aa09746 Compare June 2, 2023 11:21
@Stefan-Ethernal Stefan-Ethernal changed the title EVM-607 Example POC Hardforking example Jun 19, 2023
@Stefan-Ethernal Stefan-Ethernal added the don't merge Please don't merge this functionality temporarily label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge Please don't merge this functionality temporarily
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants