Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Block Number before deploying contracts. #1742

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Query Block Number before deploying contracts. #1742

merged 1 commit into from
Jul 31, 2023

Conversation

rzmahmood
Copy link
Contributor

Description

Please provide a detailed description of what was done in this PR

This PR modifies the setup of the genesis file so that the value set for the block tracker is before the deployment and initialization of the genesis contracts. This has two major benefits:

  1. If someone deposits in the gap between initialization and querying, their statesync event will not be missed
  2. If any state sync messages are sent during initialization of the bridge contracts, they will not be missed.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@github-actions
Copy link

github-actions bot commented Jul 25, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@rzmahmood
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@rzmahmood
Copy link
Contributor Author

recheck

1 similar comment
@rzmahmood
Copy link
Contributor Author

recheck

github-actions bot added a commit that referenced this pull request Jul 25, 2023
@github-actions
@rzmahmood has signed the CLA from Pull Request #1742
dfdb12d
@rzmahmood
Copy link
Contributor Author

recheck

@jp-imx
Copy link
Contributor

jp-imx commented Jul 25, 2023

How hard would it be to add a test to command/rootchain/deploy/deploy_test.go that's similar to TestDeployContracts_NoPanics but compares the block number to the block in which the contracts were deployed?

@rzmahmood rzmahmood mentioned this pull request Jul 25, 2023
Closed
@rzmahmood
Copy link
Contributor Author

recheck

@Stefan-Ethernal Stefan-Ethernal merged commit 3070ee0 into 0xPolygon:develop Jul 31, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rzmahmood @jp-imx @igorcrevar @Stefan-Ethernal @goran-ethernal