Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster script fix #1840

Conversation

dusannosovic-ethernal
Copy link
Contributor

@dusannosovic-ethernal dusannosovic-ethernal commented Aug 21, 2023

Description

The current problem with cluster script is the ability to introduce relayer even if IBFT is active as a consensus mechanism. Relayer may be invoked only if PolyBFT is used.

This PR fix cluster script fixes the above mentioned problem:
Script will check what kind of consensus mechanism was invoked and consequently will introduce relayer or not.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Nemanja0x Nemanja0x added the bug fix Functionality that fixes a bug label Aug 21, 2023
scripts/cluster Outdated Show resolved Hide resolved
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear what's the difference between both commands given the conditional, can we separate params composition to a variable and assign or leave the var empty given the conditions?

@Stefan-Ethernal
Copy link
Collaborator

Superseded by #1971.

@Stefan-Ethernal Stefan-Ethernal deleted the fix-cluster-script branch October 9, 2023 07:05
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants