-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement SQL lite storage #72
feat: implement SQL lite storage #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if make sense to support dbTx?
Can you elaborate some more? Do you mean to be able to do multiple changes in the same transaction (basically to ensure transactional mode)? IMO, probably doesn't make too much sense, because it is only a single table, but I'm not sure (it depends of the usage). There might be some valid use case for it 🤔 |
I don't known that is done internally but even with just 1 table make sense:
|
I discussed this with @goran-ethernal and @joanestebanr, there is no use case, where we would benefit from introducing transactional model. The transactions are affected one by one. |
26fc997
to
d3db367
Compare
4c36837
to
db40fc9
Compare
…dress comment from @arnaubennassar)
d136818
to
c009e71
Compare
Quality Gate failedFailed conditions |
What does this PR do?
This PR introduces SQL lite storage to the zkevm-eth-txmanager, in case the
PersistenceFilename
config param is provided.Reviewers
Main reviewers: