Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Deployment script throwing with latest version of docker compose v2 #128

Closed
adirola opened this issue Jun 27, 2023 · 1 comment
Closed

Comments

@adirola
Copy link
Contributor

adirola commented Jun 27, 2023

Docker Deployment script throwing with latest version of docker compose v2

Description

The current docker deployment script will not work with docker compose v2 installed and throws an error of unknown command "docker-compose"

Your environment

  • Linux (ubuntu 20.04).
  • main.
  • Running Locally.

Steps to reproduce

  • On running the docker build command "npm run docker:contracts" the deploy-docker.sh script throws the error that docker-compose command is not recognized.
  • The issue is in deploy-docker.sh script which works with docker-compose version v1 not with v2.
  • Which commands triggered the issue: npm run docker:contracts.

Expected behavior

  • We should be able to successfully create a docker image.
  • Script throws error.

Proposed solution

Either restrict the docker-compose version to be used or update the script to latest docker compose command

I could not find a contribution guide so opened a pull request with the above mentioned change. Would be happy to learn more about this and take this forward

@invocamanman
Copy link
Collaborator

Thanks for opening yourself a PR about this ^^
#129

@invocamanman invocamanman added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants