Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated deploy-docker.sh to docker compose v2 #129

Conversation

adirola
Copy link
Contributor

@adirola adirola commented Jun 27, 2023

The current docker deployment script will not work with docker compose v2 installed and throws an error of unknown command "docker-compose"

Updated the script to docker compose v2

Issue: #128

@cla-bot
Copy link

cla-bot bot commented Jun 27, 2023

We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@invocamanman
Copy link
Collaborator

Hi thank you!!!^^

But didin't this PR breaks the compatibility with the previous docker compose version?

@adirola
Copy link
Contributor Author

adirola commented Jul 2, 2023

@invocamanman yes this is a breaking change but most new users from july 2023 will only get docker compose v2. Based on this we can either restrict the docker-compose version in the repo documentation or create new script for version v2 so as to accommodate people using docker compose v2.

To avoid breaking change have introduced it as new file for version 2 and have a new command in package.json.
new file : deploy-dockerv2.sh
new command : dockerv2:contracts

@cla-bot
Copy link

cla-bot bot commented Jul 2, 2023

We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@invocamanman
Copy link
Collaborator

This actually seems better! thank you so much!
I think you just have to sign the CLA and that's it ^^

@invocamanman
Copy link
Collaborator

invocamanman commented Jul 5, 2023

Also pls correct the file name docker/scripts/deploy-dockerc2.sh --> docker/scripts/deploy-dockerv2.sh and squash everything in one commit^^

@cla-bot
Copy link

cla-bot bot commented Jul 7, 2023

We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@adirola adirola force-pushed the feature/fixDockerDeploymentScript branch from 26b486a to fb84ab8 Compare July 7, 2023 04:00
@cla-bot
Copy link

cla-bot bot commented Jul 7, 2023

We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Jul 7, 2023

We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@adirola adirola force-pushed the feature/fixDockerDeploymentScript branch from bcc1a33 to 7e53619 Compare July 7, 2023 04:02
@cla-bot
Copy link

cla-bot bot commented Jul 7, 2023

We require contributors/corporates @adirola to read our Contributor License Agreement, please check the Individual CLA document/Corporate CLA document

@adirola
Copy link
Contributor Author

adirola commented Jul 7, 2023

Hey @invocamanman thanks for the guidance, as mentioned in comments i have updated the file name and squashed the commit into single commit.
I have also raised a similar pull request to add my username into cla-config to sign cla, would appreciate if you can help me in this.

@invocamanman
Copy link
Collaborator

invocamanman commented Jul 7, 2023

you should be added to the CLA, try to change a commit name or something to reset the bot pls^^

@adirola adirola force-pushed the feature/fixDockerDeploymentScript branch from 7e53619 to 3fae829 Compare July 7, 2023 14:36
@cla-bot cla-bot bot added the cla-signed label Jul 7, 2023
@adirola
Copy link
Contributor Author

adirola commented Jul 7, 2023

Done @invocamanman, i think its good to merge from my end.
Once merged i guess next step is to update the documentation for building docker image?

@adirola adirola requested a review from invocamanman July 7, 2023 14:44
@invocamanman invocamanman merged commit 36ba208 into 0xPolygonHermez:develop Jul 7, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants