Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create rollup deployment script #206

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Fix create rollup deployment script #206

merged 1 commit into from
Mar 5, 2024

Conversation

Stefan-Ethernal
Copy link
Contributor

@Stefan-Ethernal Stefan-Ethernal commented Mar 5, 2024 •
edited
Loading

The PR fixes create rollup deployment script. There were missing Address suffixes on a couple of places for polygonRollupManager SC address.

@cla-bot cla-bot bot added the cla-signed label Mar 5, 2024
@Stefan-Ethernal Stefan-Ethernal changed the base branch from main to develop March 5, 2024 13:57
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@invocamanman
Copy link
Collaborator

Thank youu! ^^

@invocamanman invocamanman merged commit 47e4834 into develop Mar 5, 2024
5 of 6 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the fix/create-rollup-deployment-script branch March 5, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invocamanman invocamanman invocamanman approved these changes

@arnaubennassar arnaubennassar Awaiting requested review from arnaubennassar

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Stefan-Ethernal @invocamanman