Use the go-ethereum v1.14.3 Docker image
#250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
changed the title
go-ethereum Docker image
Stefan-Ethernal
changed the title
go-ethereum Docker imagego-ethereum v1.13.15 Docker image
Stefan-Ethernal
changed the title
go-ethereum v1.13.15 Docker imagego-ethereum v1.14.3 Docker image
|
invocamanman
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
zkevm-noderecently introduced the L1 Safe Block synchronization feature (0xPolygonHermez/zkevm-node#3545), and is running the synchronizer withsafeorfinalizedforSynchronizer.SyncBlockProtection,Synchronizer.L1BlockCheck.L1SafeBlockPointetc., we should use the newer Geth docker image, to overcome the error being returned by some earlier versions of Geth (namely 1.12.x) when querying the blocks with thesafeorfinalizedfilters. This is the PR that fixed it on thego-ethereum(ethereum/go-ethereum#27799), so instead of returning an error when the RPC request with thesafeorfinalizedoption is provided, it defers to the blockchain whether error should be returned or not.