Refactor indexL1InfoRoot to l1InfoTreeLeafCount #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignasirv
requested review from
invocamanman,
krlosMata and
laisolizq
as code owners
krlosMata
requested changes
Aug 20, 2024
| @@ -90,7 +90,7 @@ contract PolygonValidiumEtrog is PolygonRollupBaseEtrog, IPolygonValidium { | |||
| */ | |||
| function sequenceBatchesValidium( | |||
| ValidiumBatchData[] calldata batches, | |||
| uint32 indexL1InfoRoot, | |||
| uint32 l1InfoRootLeafcount, | |||
There was a problem hiding this comment.
Suggested change
| uint32 l1InfoRootLeafcount, | |
| uint32 l1InfoRootLeafCount, |
camelCase xD
There was a problem hiding this comment.
this applies for all namings
There was a problem hiding this comment.
maybe it is better l1InfoTreeLeafCount ?
instead of root
ignasirv
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.