Add rollupManager initializer versioning #314
Conversation
| * Initializer function to set new rollup manager version | ||
| */ | ||
| function initialize() external virtual reinitializer(3) { | ||
| emit UpdateRollupManagerVersion("banana"); |
There was a problem hiding this comment.
Add constant instead ^^
ignasirv
force-pushed
the
feature/rm-versioning
branch
from
d8c127d
to
00266ab
Compare
| @@ -231,6 +231,8 @@ contract PolygonRollupManager is | |||
| bytes32 internal constant _EMERGENCY_COUNCIL_ADMIN = | |||
| keccak256("EMERGENCY_COUNCIL_ADMIN"); | |||
|
|
|||
| string internal constant _ROLLUP_MANAGER_VERSION_PESSIMISTIC = "pessimistic"; | |||
There was a problem hiding this comment.
maybe it's worth it to have a constnat that always have the same name, and public, to be able to easy retrieval from the node 🤔 something like currentVersion!?¿
There was a problem hiding this comment.
yep, agree. See comment above xD
| @@ -231,6 +231,8 @@ contract PolygonRollupManager is | |||
| bytes32 internal constant _EMERGENCY_COUNCIL_ADMIN = | |||
| keccak256("EMERGENCY_COUNCIL_ADMIN"); | |||
|
|
|||
| string internal constant _ROLLUP_MANAGER_VERSION_PESSIMISTIC = "pessimistic"; | |||
There was a problem hiding this comment.
I would make this public, so it is easy to check from the SC directly.
Also, _ROLLUP_MANAGER_VERSION_PESSIMISTIC should have a generic naming like _ROLLUP_MANAGER_VERSION and it value reflects the version.
| @@ -231,6 +231,8 @@ contract PolygonRollupManager is | |||
| bytes32 internal constant _EMERGENCY_COUNCIL_ADMIN = | |||
| keccak256("EMERGENCY_COUNCIL_ADMIN"); | |||
|
|
|||
| string internal constant _ROLLUP_MANAGER_VERSION_PESSIMISTIC = "pessimistic"; | |||
There was a problem hiding this comment.
yep, agree. See comment above xD
| @@ -270,6 +270,9 @@ contract PolygonRollupManager is | |||
| // Last timestamp when an aggregation happen | |||
| uint64 public lastAggregationTimestamp; | |||
|
|
|||
| // Current rollup manager version | |||
| string public constant ROLLUP_MANAGER_VERSION = "pessimistic"; | |||
There was a problem hiding this comment.
move it to constants part of the file^^
|
No description provided.