Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set verifiers forkID & add README in updateRollup tool #323

Merged
merged 2 commits into from
Sep 12, 2024
Merged

set verifiers forkID & add README in updateRollup tool #323

merged 2 commits into from
Sep 12, 2024

Conversation

krlosMata
Copy link
Contributor

This PR does the following:

  • minor fixes on tool addRollupType (imported from main branch)
  • keep old verifiers (forkID 10 & 11)
  • rename verifier to include 12 (forkID)
  • tool updateRollup
    • add .gitignore
    • add ability to just call the Sc directly from an EOA address
    • minor improvements

@cla-bot cla-bot bot added the cla-signed label Sep 10, 2024
ignasirv
ignasirv approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@ignasirv ignasirv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 12, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
70.9% Duplication on New Code

See analysis details on SonarCloud

@krlosMata krlosMata merged commit 922d548 into develop Sep 12, 2024
7 checks passed
@bharathbvgp bharathbvgp mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invocamanman invocamanman invocamanman approved these changes

@ignasirv ignasirv ignasirv approved these changes

@laisolizq laisolizq Awaiting requested review from laisolizq laisolizq is a code owner

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krlosMata @ignasirv @invocamanman