chore: remove port forwarding #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OBrezhniev
reviewed
Sep 17, 2024
README.md
Outdated
| * http://localhost:8088/ to access the UI | ||
| * http://localhost:3001/ to access the API. | ||
| * https://localhost:8088/ to access the UI | ||
| * <PUBLICLY_ACCESSIBLE_URL_POINTING_TO_ISSUER_SERVER_PORT>:3001/ to access the API. (**user: user-issuer**, **password: password-issuer**) |
There was a problem hiding this comment.
"Default user name / password are: ..."
"You can set them using env vars(link to proper readme section)"
.env-ui.sample
Outdated
| ISSUER_UI_INSECURE=true |
There was a problem hiding this comment.
Probably better to keep false here
README.md
Outdated
|
|
||
| 6. Import your private Key: | ||
| Write the private key in Vault. This step is needed in order to be able to transit the issuer's state. To perform that | ||
| 6. Import your metamask private Key: |
There was a problem hiding this comment.
Not metamask, but Ethereum private key.
README.md
Outdated
| 6. Import your private Key: | ||
| Write the private key in Vault. This step is needed in order to be able to transit the issuer's state. To perform that | ||
| 6. Import your metamask private Key: | ||
| Write the private. This step is needed in order to be able to transit the issuer's state. To perform that |
There was a problem hiding this comment.
"Configure the private key. This step..."
README.md
Outdated
|
|
||
| #### Running issuer node with vault instead of local storage file | ||
| The issuer node can be configured to use a local storage, that is, a local file, as kms provider. | ||
| This alternative can be useful in development or testing environments. To do it: | ||
| The issuer node can be configured to use a [Vault](https://www.vaultproject.io), as kms provider. |
README.md
Outdated
| The issuer node can be configured to use a local storage, that is, a local file, as kms provider. | ||
| This alternative can be useful in development or testing environments. To do it: | ||
| The issuer node can be configured to use a [Vault](https://www.vaultproject.io), as kms provider. | ||
| However, in addition to the vault, the vault needs a [plugin](https://github.com/iden3/vault-plugin-secrets-iden3) |
There was a problem hiding this comment.
However Vault needs a plugin...
OBrezhniev
reviewed
Sep 17, 2024
| a4a1d3ec9159 redis:6-alpine "docker-entrypoint.s…" 38 seconds ago Up 36 seconds (healthy) 6379/tcp issuer-redis-1 | ||
| ``` | ||
|
|
||
|
|
|
A few minor things in readme. Otherwise LGTM. |
x1m3
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.