Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MassaLabs : Use a block syntax for declarations and statements blocks #350

Merged
merged 1 commit into from
Apr 21, 2024
Merged

MassaLabs : Use a block syntax for declarations and statements blocks #350

merged 1 commit into from
Apr 21, 2024

Conversation

AurelienFT
Copy link

Implements the RFC : #331

@bobbinth bobbinth requested a review from bitwalker April 10, 2024 17:38
bitwalker
bitwalker approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@bitwalker bitwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Definitely a pain to have to go through and update all the existing AIR syntax and tests 😅, the effort is much appreciated!

@bobbinth I'll let you merge this at your discretion, but 👍 from me

bobbinth
bobbinth approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

A question (for a potential different PR): since we are adopting a more C-like syntax, should we also use semicolons for statement terminators?

@bobbinth bobbinth merged commit 5427353 into 0xPolygonMiden:next Apr 21, 2024
4 checks passed
@bobbinth bobbinth mentioned this pull request Apr 21, 2024
Merged
@bobbinth bobbinth mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwalker bitwalker bitwalker approved these changes

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurelienFT @bitwalker @bobbinth