Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: basic wallet account compilation #187

Merged
merged 4 commits into from
May 22, 2024

Conversation

bitwalker
Copy link
Contributor

This PR applies some fixes that were causing the basic wallet account code from #186 to hit asserts in the backend. Once merged, the only remaining blockers are related to felts, stores of complex types, load/store reordering, and operand stack overflow handling.

@bitwalker bitwalker added bug Something isn't working codegen blocker This issue is one of our top priorities labels May 21, 2024
@bitwalker bitwalker requested a review from greenhat May 21, 2024 19:32
@bitwalker bitwalker self-assigned this May 21, 2024
Copy link
Contributor

@greenhat greenhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bitwalker bitwalker merged commit 9bf78c5 into main May 22, 2024
3 checks passed
@bitwalker bitwalker deleted the bitwalker/account-compilation-fixes branch May 22, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker This issue is one of our top priorities bug Something isn't working codegen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants