fix: cargo release by adding help feature to clap dependency
#288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since `cargo build` seems ignore `default-features` on the workspace level and enables default features for inherited dependencies. `cargo release` OTOH seems to behave correctly and does not ignore `default-features` on the workspace level and the build fails due to `Command::help_template` is hidden behind the `help` feature.
|
Close in favor of #289 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
cargo buildseems to ignoredefault-featureson the workspace level and enables default features for inherited dependencies.cargo releaseOTOH seems to behave correctly and does not ignoredefault-featureson the workspace level, and the build fails due toCommand::help_templateis hidden behind thehelpfeature.This PR fixes the https://github.com/0xPolygonMiden/compiler/actions/runs/10604566214/job/29391504068 build error during the
cargo release