chore: add CompilerTestInputType::CargoMiden and use cargo-miden build it
#313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwalker
reviewed
Sep 12, 2024
tests/integration/Cargo.toml
Outdated
| @@ -31,6 +31,7 @@ midenc-codegen-masm.workspace = true | |||
| midenc-session.workspace = true | |||
| midenc-compile.workspace = true | |||
| midenc-debug.workspace = true | |||
| cargo-miden = { path = "../../tools/cargo-miden" } | |||
There was a problem hiding this comment.
Suggestion: We may as well add cargo-miden to the workspace Cargo.toml, since it's going to get picked up as a dependency at the workspace level anyway due to its presence here.
bitwalker
approved these changes
Sep 12, 2024
greenhat
force-pushed
the
greenhat/i312-use-cargo-miden-in-itests
branch
from
aeeb0ce
to
18540d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #312
The
CompilerInputTestType::CargoComponentwill be removed, and all relevant tests will be switched to theCargoMidenvariant after the #90 and #308 are implemented.