Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove miden-assembly dependency from sdk/base-sys for bindings feature #326

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore: remove miden-assembly dependency from sdk/base-sys for bindings feature #326

merged 1 commit into from
Sep 17, 2024

Conversation

greenhat
Copy link
Contributor

Use miden-assembly dependency only when building MASL library.

@greenhat greenhat marked this pull request as ready for review September 17, 2024 09:41
bitwalker
bitwalker approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@bitwalker bitwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that might speed up compilation a bit

@bitwalker bitwalker merged commit 4b0c16b into next Sep 17, 2024
5 checks passed
@bitwalker bitwalker deleted the greenhat/miden-base-sys-no-deps-in-bindings branch September 17, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwalker bitwalker bitwalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greenhat @bitwalker