Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v0.0.7 #328

Merged
merged 29 commits into from
Sep 17, 2024
Merged

Merge v0.0.7 #328

merged 29 commits into from
Sep 17, 2024

Commits on Sep 6, 2024

  1. chore: bump msrv to 1.80

    bitwalker committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1b4a92c View commit details
    Browse the repository at this point in the history
  2. release: 0.0.6

    bitwalker committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    b08386c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c8ab278 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    ab9e353 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #311 from 0xPolygonMiden/greenhat/add-semver-check…

    …s-contributing
    
    chore: add `cargo-semver-checks` install to the CONTRIBUTING.md
    bitwalker authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    e1c3e88 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    5947e41 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. chore: fallback to cwd if CARGO_MANIFEST_DIR env var is not set

    Needed when running `cargo flamegraph --root` for #317
    greenhat committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    173c48b View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Merge pull request #318 from 0xPolygonMiden/greenhat/env-var-fallback…

    …-itest
    
    chore: fallback to cwd if CARGO_MANIFEST_DIR env var is not set
    bitwalker authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a123934 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18540d0 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #313 from 0xPolygonMiden/greenhat/i312-use-cargo-m…

    …iden-in-itests
    
    chore: add `CompilerTestInputType::CargoMiden` and use `cargo-miden` build it
    greenhat authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d60dce5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2562ca6 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #315 from 0xPolygonMiden/docs/copy-edit-1

    docs: first pass applying Polygon-wide documentation standards
    bitwalker authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    83e234b View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Configuration menu
    Copy the full SHA
    9a9242c View commit details
    Browse the repository at this point in the history
  2. Merge pull request #321 from 0xPolygonMiden/greenhat/update-cargo-com…

    …ponent-0-16
    
    chore: update cargo-component to v0.16.0
    bitwalker authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e3623ba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bfad773 View commit details
    Browse the repository at this point in the history
  4. chore: update deps

    bitwalker committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    df16a23 View commit details
    Browse the repository at this point in the history
  5. ci: rework github actions workflows

    * Replace unmaintained actions-rs steps with manual steps
    * Rely on rust-toolchain.toml file for installing required toolchain,
      targets and components. This also cleans up Makefile.toml a bit
    * Improve the way we handle build caches using Swatinem/rust-cache. See
      below for details.
    * Restructure jobs to run lint/formatter checks and tests in parallel,
      but introduce some ordering in those groups to improve cache coherency
      and reuse, and in some cases, to avoid running expensive actions which
      are very likely to fail anyway. The main difference here is that
      amongst the test group, the unit test job is run first, followed by
      the midenc and cargo-miden integration test jobs. Previously only the
      cargo-miden integration tests were split out into a separate job. By
      breaking apart unit and integration tests, we can fail fast when unit
      tests are broken, and avoid running the expensive integration tests
      when they are very likely to fail if the unit tests are broken.
    * Update the `book.yml` workflow to publish our new mkdocs-based
      documentation, rather than the old mdbook-based docs. This was causing
      the workflow to fail, it should now start working again.
    
    RE: caching in CI. See https://github.com/Swatinem/rust-cache for
    details on how the caching step works, particularly _what_ is cached,
    how it is keyed, and _when_ it is cached.
    
    The changes in this commit cache the results of a successful run _only_
    when a push to the 'next' branch occurs, i.e. when a PR is merged. Thus,
    all PR runs will use the cache associated with the last successful build
    of `next` as a base, and build off of that.
    
    Furthermore, there are three different caches:
    
    * The cache shared by non-test jobs in the `ci.yml` workflow
    * The cache shared by test jobs in the `ci.yml` workflow
    * The cache used by the release job in the `release.yml` workflow
    
    Previous to this commit, each job had its own cache, and the cache would
    be updated on every successful build, causing a fair amount of cache
    instability, and resulting in very little reuse.
    
    This commit is more conservative about updating the cache, but shares it
    more broadly across jobs, and the more conservative baseline means that
    the cache is hit more frequently across all PRs.
    
    The choice to not share the cache between non-test and test jobs in the
    `ci.yml` workflow is because we want to maximize the number of jobs that
    run in parallel, but to reuse the cache, we must ensure that only one
    job is responsible for maintaining it. If we maximized cache reuse, we'd
    run all jobs in sequence, but this would be slow. Instead, we break up
    the workflow into non-test checks, and tests, and pick a baseline job in
    both groups to handle maintaining the cache for that group. These groups
    can then be run in parallel, and after the job that maintains the cache
    is run, all remaining jobs in that group can be run in parallel.
    bitwalker committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    e959fc8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6d9dba3 View commit details
    Browse the repository at this point in the history
  7. ci(rustfmt): disable wrap_comments due to broken behavior

    wrap_comments does not interact well with complex Markdown lists, of
    which we have multiple. In general it is still an unstable feature and
    not totally reliable, so disabling for now
    bitwalker committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5d9c543 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f0f56ac View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge pull request #322 from 0xPolygonMiden/bitwalker/rust-toolchain

    chore: update rust toolchain and rework ci workflows
    bitwalker authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dfc7f84 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    29491a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. fix: switch cargo-miden to v0.4.0 of the new project template with

    `dev` profile to fix the #323 compilation issue.
    Add a test to build the new project with `dev` profile.
    greenhat committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    31ad4ce View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7639039 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #324 from 0xPolygonMiden/greenhat/i323-fix-guide

    doc: add `--release` option to `cargo miden build` command
    bitwalker authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    479f29f View commit details
    Browse the repository at this point in the history
  4. Merge pull request #325 from 0xPolygonMiden/greenhat/i323-dev-profile…

    …-in-new-proj-template
    
    Switch cargo-miden to v0.4.0 of the new project template with `dev` profile to fix the #323 compilation issue
    bitwalker authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    5211b74 View commit details
    Browse the repository at this point in the history
  5. Merge pull request #326 from 0xPolygonMiden/greenhat/miden-base-sys-n…

    …o-deps-in-bindings
    
    chore: remove `miden-assembly` dependency from `sdk/base-sys` for `bindings` feature
    bitwalker authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4b0c16b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3ea1702 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8076326 View commit details
    Browse the repository at this point in the history