feat: implement clz/ctz instructions #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwalker
force-pushed
the
bitwalker/clz-ctz
branch
from
0368341
to
7d689b7
Compare
|
NOTE: I'm adding some tests for this, as found some issues (not with the intrinsics, but somewhere in the emulator I think when testing the behavior, something to do with how memory and the operand stack interoperate, I'll fix it tomorrow when I have a moment) |
|
I made #44 for Wasm translation. |
greenhat
reviewed
Oct 20, 2023
There was a problem hiding this comment.
Looking good!
I could not check the MASM code of the intrinsics in my head due to its complexity. So having tests for them would be nice, but I'm recalling from the discord thread that these ops will be implemented in VM soon, so I guess we can afford to skip the tests for now.
I saw your note but missed the revert of the status to draft. I'll do another round when its ready.
bitwalker
force-pushed
the
bitwalker/i32
branch
from
6d95c52
to
9586b41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on changes in #37, and adds implementations of
clzandctzfor integral types up to 32 bits.In this PR, a couple of small tweaks/fixes as well:
loc_storeandloc_storew, which we use in one of the new intrinsicscodegen/masm/intrinsicsrust-wasm-testsfrom workspace members, since it is compiled and run with a separate build profile viafrontend-wasm's test suite. When added as a workspace member the profilerust-wasm-testsdefines is ignored, so it's not going to do what we expect. We'll catch any issues with that crate when CI runs our tests anyway.Closes #39