Add missing methods to Smt
#268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
requested changes
Jan 30, 2024
src/merkle/smt/full/mod.rs
Outdated
Comment on lines
323
to
329
| for (key_in_leaf, value_in_leaf) in self.entries() { | ||
| if key == key_in_leaf { | ||
| return *value_in_leaf; | ||
| } | ||
| } | ||
|
|
||
| EMPTY_WORD |
There was a problem hiding this comment.
Maybe the compiler can optimize this away, but I'd prefer to handle it using a match statement to avoid potential unnecessary allocations.
src/merkle/smt/full/mod.rs
Outdated
Comment on lines
119
to
121
| let leaf = self.get_leaf(key); | ||
|
|
||
| leaf.get_value(key) |
There was a problem hiding this comment.
Similar comment as above: this may result in closing of the leaf first and then getting a value from it. May be better to make sure we don't rely on the compiler for optimizing away unnecessary cloning/allocations.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #250