feat: remove DeserializationError from TransactionProverErrors

0xPolygonMiden · Sep 26, 2024 · 1cbb27d · 1cbb27d
1 parent 8ed4820
commit 1cbb27d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/bin/tx-prover/src/server/mod.rs b/bin/tx-prover/src/server/mod.rs
@@ -1,8 +1,9 @@
 use generated::api::{api_server, ProveTransactionRequest, ProveTransactionResponse};
 use miden_objects::transaction::{ProvenTransaction, TransactionWitness};
+use miden_prover::DeserializationError;
 use miden_tx::{
     utils::{Deserializable, Serializable},
-    LocalTransactionProver, TransactionProver, TransactionProverError,
+    LocalTransactionProver, TransactionProver,
 };
 use tokio::{net::TcpListener, sync::Mutex};
 use tonic::{Request, Response, Status};
@@ -66,11 +67,10 @@ impl From<ProvenTransaction> for ProveTransactionResponse {
 }
 
 impl TryFrom<ProveTransactionResponse> for ProvenTransaction {
-    type Error = TransactionProverError;
+    type Error = DeserializationError;
 
     fn try_from(response: ProveTransactionResponse) -> Result<Self, Self::Error> {
         ProvenTransaction::read_from_bytes(&response.proven_transaction)
-            .map_err(|err| TransactionProverError::DeserializationError(err.to_string()))
     }
 }
 

diff --git a/miden-tx/src/errors/mod.rs b/miden-tx/src/errors/mod.rs
@@ -48,7 +48,6 @@ pub enum TransactionProverError {
     InvalidTransactionOutput(TransactionOutputError),
     ProvenTransactionError(ProvenTransactionError),
     TransactionHostCreationFailed(TransactionHostError),
-    DeserializationError(String),
 }
 
 impl Display for TransactionProverError {
@@ -69,9 +68,6 @@ impl Display for TransactionProverError {
             TransactionProverError::TransactionHostCreationFailed(inner) => {
                 write!(f, "Failed to create the transaction host: {}", inner)
             },
-            TransactionProverError::DeserializationError(inner) => {
-                write!(f, "Deserialization error: {}", inner)
-            },
         }
     }
 }